linux-kernel - Re: [PATCH RESEND 2/2] regulator: mt6397: Add buck change mode regulator interface for mt6397

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160511145046.GI6261@sirena.org.uk>
Date:	Wed, 11 May 2016 15:50:46 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Henry Chen <henryc.chen@...iatek.com>
Cc:	Rob Herring <robh+dt@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Stephen Boyd <sboyd@...eaurora.org>,
	Bjorn Andersson <bjorn.andersson@...ymobile.com>,
	Laxman Dewangan <ldewangan@...dia.com>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH RESEND 2/2] regulator: mt6397: Add buck change mode
 regulator interface for mt6397

On Wed, May 11, 2016 at 05:31:30PM +0800, Henry Chen wrote:

> +The possible values for "regulator-supported-modes" are:
> +	0: PWM mode, mapping to regulator fast mode, allow the
> +	converter to remain in the PWM mode regardless of the load current, so
> +	that the noise spectrum of the converter can be minimized for certain
> +	highly-noise-sensitive handset applications.
> +	1: Auto mode, mapping to regulator normal mode, mode switch by current
> +	loading. At light load currents, the converter automatically enters
> +	PFM mode to save power and improve light load efficiency. At heavy
> +	load currents, the converter automatically enters PWM mode to minimiz
> +	the noise spectrum of the converter.

The details of how this maps onto Linux shouldn't be in the bindings.

> +				regulator-allow-change-mode;
> +				regulator-supported-modes = <0 1>;

These are problematic too as covered in my other mail. 

> -static struct regulator_ops mt6397_volt_range_ops = {
> +static const struct regulator_ops mt6397_volt_range_ops = {

The constification is fine but an unrelated change.  Otherwise this
looks fine from a code point of view, let's get that merged separately.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)