linux-kernel - Re: [PATCH] xen: remove incorrect forward declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 May 2016 16:19:10 +0100
From:	Ross Lagerwall <ross.lagerwall@...rix.com>
To:	Juergen Gross <jgross@...e.com>, Arnd Bergmann <arnd@...db.de>,
	"David Vrabel" <david.vrabel@...rix.com>
CC:	<stable@...r.kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>,
	Daniel Kiper <daniel.kiper@...cle.com>,
	Julien Grall <julien.grall@...rix.com>,
	Stefano Stabellini <stefano.stabellini@...citrix.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Vitaly Kuznetsov <vkuznets@...hat.com>,
	"Paul Gortmaker" <paul.gortmaker@...driver.com>,
	<xen-devel@...ts.xenproject.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] xen: remove incorrect forward declaration

On 05/11/2016 03:05 PM, Juergen Gross wrote:
> On 11/05/16 15:07, Arnd Bergmann wrote:
>> A bugfix patch for the xen balloon driver introduced a forward
>> declaration for a static function that is conditionally compiled,
>> causing a warning if only the declaration but not the definition
>> are there:
>>
>> drivers/xen/balloon.c:154:13: error: 'release_memory_resource' declared 'static' but never defined [-Werror=unused-function]
>>   static void release_memory_resource(struct resource *resource);
>>
>> This removes the declaration again and instead moves the function
>> definition to the right place, before its first caller and inside
>> of the #ifdef protecting both.
>>
>> The patch that introduced the warning is marked for stable
>> backports, so if that gets applied to 4.4, so should this one.
>>
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> Fixes: dfd74a1edfab ("xen/balloon: Fix crash when ballooning on x86 32 bit PAE")
>> Cc: stable@...r.kernel.org
>
> So you've CC'ed Ross, who sent the very same patch just yesterday, but
> without the backport request.
>

Well it wasn't clear to me whether it should be the maintainer or the 
patch submitter who should request the backport and 
Documentation/SubmittingPatches is not clear about it. Regardless, the 
build fix should be backported to 4.4.

-- 
Ross Lagerwall