linux-kernel - Re: [PATCH] drm: mediatek: add COMMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1462982733.2924.36.camel@pengutronix.de>
Date:	Wed, 11 May 2016 18:05:33 +0200
From:	Philipp Zabel <p.zabel@...gutronix.de>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	David Airlie <airlied@...ux.ie>,
	Matthias Brugger <matthias.bgg@...il.com>,
	Bibby Hsieh <bibby.hsieh@...iatek.com>,
	YT Shen <yt.shen@...iatek.com>,
	Mao Huang <littlecvr@...omium.org>,
	Jitao Shi <jitao.shi@...iatek.com>, CK Hu <ck.hu@...iatek.com>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] drm: mediatek: add COMMON_CLK dependency

Am Mittwoch, den 11.05.2016, 14:34 +0200 schrieb Arnd Bergmann:
> On kernel builds without COMMON_CLK, the newly added mediatek drm
> driver fails to build:
> 
> drivers/gpu/drm/mediatek/mtk_mipi_tx.c:130:16: error: field 'pll_hw' has incomplete type
>   struct clk_hw pll_hw;
>                 ^~~~~~
> In file included from ../include/linux/clk.h:16:0,
>                  from ../drivers/gpu/drm/mediatek/mtk_mipi_tx.c:14:
> drivers/gpu/drm/mediatek/mtk_mipi_tx.c: In function 'mtk_mipi_tx_from_clk_hw':
> include/linux/kernel.h:831:48: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
>   const typeof( ((type *)0)->member ) *__mptr = (ptr); \
>                                                 ^
> /drivers/gpu/drm/mediatek/mtk_mipi_tx.c:136:9: note: in expansion of macro 'container_of'
>   return container_of(hw, struct mtk_mipi_tx, pll_hw);
>          ^~~~~~~~~~~~
> drivers/gpu/drm/mediatek/mtk_mipi_tx.c: At top level:
> drivers/gpu/drm/mediatek/mtk_mipi_tx.c:302:21: error: variable 'mtk_mipi_tx_pll_ops' has initializer but incomplete type
>  static const struct clk_ops mtk_mipi_tx_pll_ops = {
> 
> This adds the required Kconfig dependency.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Philipp Zabel <p.zabel@...gutronix.de>

regards
Philipp