linux-kernel - Re: [PATCH v3] platform/chrome: Add Chrome OS keyboard backlight LEDs support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160511175755.GA21847@localhost>
Date:	Wed, 11 May 2016 10:57:55 -0700
From:	Olof Johansson <olof@...om.net>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Rhard Purdie <rpurdie@...ys.net>,
	Jacek Anaszewski <j.anaszewski@...sung.com>,
	Duncan Laurie <dlaurie@...omium.org>,
	Simon Que <sque@...omium.org>, Bryan Wu <cooloney@...il.com>,
	Guenter Roeck <groeck@...omium.org>,
	Evan McClain <aeroevan@...il.com>,
	linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org
Subject: Re: [PATCH v3] platform/chrome: Add Chrome OS keyboard backlight
 LEDs support

On Tue, Mar 08, 2016 at 11:12:46AM -0800, Dmitry Torokhov wrote:
> This is a driver for ACPI-based keyboard backlight LEDs found on
> Chromebooks. The driver locates \\_SB.KBLT ACPI device and exports
> backlight as "chromeos::kbd_backlight" LED class device in sysfs.
> 
> Signed-off-by: Simon Que <sque@...omium.org>
> Signed-off-by: Duncan Laurie <dlaurie@...omium.org>
> Tested-by: Evan McClain <aeroevan@...il.com>
> Signed-off-by: Dmitry Torokhov <dtor@...omium.org>
> ---
> 
> Changes from previous submissions:
> 
> v2->v3:
> - dropped call to platform_set_drvdata() as suggested by Guenter
> 
> v1->v2:
> - moved from drivers/leds to drivers/platform/chrome
> - added method to retrieve brightness from ACPI
> - renamed to cros_kbd_led_backlight
> - config option renamed to CROS_KBD_LED_BACKLIGHT
> - no longer setting initial brightness to max brightness (although on
>   Pixel 1 - Link - ACPI initially reports 100 as brightness anyway)

Ugh. I dropped the ball on this and other patches. Applied now.


-Olof