linux-kernel - Re: [PATCH v3] platform/chrome: cros_ec_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160511175813.GB21847@localhost>
Date:	Wed, 11 May 2016 10:58:13 -0700
From:	Olof Johansson <olof@...om.net>
To:	Gwendal Grignou <gwendal@...omium.org>
Cc:	rdunlap@...radead.org, olofj@...omium.org,
	alan@...rguk.ukuu.org.uk, cernekee@...omium.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] platform/chrome: cros_ec_dev - Fix security issue

On Tue, Mar 08, 2016 at 09:13:52AM -0800, Gwendal Grignou wrote:
> Prevent memory scribble by checking that ioctl buffer size parameters
> are sane.
> Without this check, on 32 bits system, if .insize = 0xffffffff - 20 and
> .outsize the amount to scribble, we would overflow, allocate a small
> amounts and be able to write outside of the malloc'ed area.
> Adding a hard limit allows argument checking of the ioctl. With the
> current EC, it is expected .insize and .outsize to be at around 512 bytes
> or less.
> 
> Signed-off-by: Gwendal Grignou <gwendal@...omium.org>

Applied now.


-Olof