linux-kernel - [PATCH 3/3] usb: gr_udc: Remove unnecessary platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 May 2016 18:16:01 +0530
From:	Sandhya Bankar <bankarsandhya512@...il.com>
To:	balbi@...nel.org, gregkh@...uxfoundation.org,
	r.baldyga@...sung.com, bankarsandhya512@...il.com,
	saurabh.truth@...il.com, peter.chen@...escale.com,
	Julia.Lawall@...6.fr, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH 3/3] usb: gr_udc: Remove unnecessary platform_set_drvdata().

Unnecessary [platform|pci]_set_drvdata() have been removed since the driver core clears the driver data to NULLafter device release or on probe failure. There is no need to manually clear the device driver data to NULL.

Signed-off-by: Sandhya Bankar <bankarsandhya512@...il.com>
---
 drivers/usb/gadget/udc/gr_udc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/gr_udc.c b/drivers/usb/gadget/udc/gr_udc.c
index 39b7136..05f956c 100644
--- a/drivers/usb/gadget/udc/gr_udc.c
+++ b/drivers/usb/gadget/udc/gr_udc.c
@@ -2117,7 +2117,6 @@ static int gr_remove(struct platform_device *pdev)
 
 	gr_dfs_delete(dev);
 	dma_pool_destroy(dev->desc_pool);
-	platform_set_drvdata(pdev, NULL);
 
 	gr_free_request(&dev->epi[0].ep, &dev->ep0reqi->req);
 	gr_free_request(&dev->epo[0].ep, &dev->ep0reqo->req);
-- 
1.8.3.4