linux-kernel - Re: [1/1] mm: thp: calculate the mapcount correctly for THP pages during WP faults

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160511212552.GA20578@phlsvsds.ph.intel.com>
Date:	Wed, 11 May 2016 17:26:16 -0400
From:	Mike Marciniszyn <mike.marciniszyn@...el.com>
To:	Andrea Arcangeli <aarcange@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: [1/1] mm: thp: calculate the mapcount correctly for THP pages during WP faults

>
>Reviewed-by: "Kirill A. Shutemov" <kirill@...temov.name>
>Signed-off-by: Andrea Arcangeli <aarcange@...hat.com>
>

Our RDMA tests are seeing an issue with memory locking that bisects to
commit 61f5d698cc97 ("mm: re-enable THP").

The test program registers two rather large MRs (512M) and RDMA writes
data to a passive peer using the first and RDMA reads it back into the
second MR and compares that data.  The sizes are chosen randomly between
0 and 1024 bytes.

The test will get through a few (<= 4 iterations) and then gets a compare error.

Tracing indicates the kernel logical addresses associated with the individual
pages at registration ARE correct , the data in the "RDMA read response only"
packets ARE correct.

The “corruption” occurs when the packet crosse two pages that are not
physically contiguous.   The second page reads back as zero in the program.

It looks like the user VA at the point of the compare error no longer points
to the same physical address as was registered.  

This patch totally resolves the issue!

Tested-by: Mike Marciniszyn <mike.marciniszy@...el.com>
Tested-by: Josh Collier <josh.d.collier@...el.com>