linux-kernel - Re: [PATCH] x86: use compat version for preadv2 and pwritev2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160512073037.GA3852@lst.de>
Date:	Thu, 12 May 2016 09:30:37 +0200
From:	Christoph Hellwig <hch@....de>
To:	"Dmitry V. Levin" <ldv@...linux.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Christoph Hellwig <hch@....de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: use compat version for preadv2 and pwritev2

On Wed, May 11, 2016 at 11:48:17AM +0300, Dmitry V. Levin wrote:
> Similar to preadv and pwritev, preadv2 and pwritev2 need compat entries
> in the 32-bit syscall table.
> 
> This bug was found by strace test suite.

Looks fine, thanks.

Btw, can we have a sensible format for the syscalls list that explicitly
requires adding _something_ for the compat entry so that errors by
ommision like this can't happen?

Reviewed-by: Christoph Hellwig <hch@....de>