linux-kernel - Re: [RFC PATCH 5/8] KEYS: Provide software public key query function [ver 3]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 May 2016 11:19:23 +0100
From:	David Howells <dhowells@...hat.com>
To:	Mat Martineau <mathew.j.martineau@...ux.intel.com>,
	tadeusz.struk@...el.com
Cc:	dhowells@...hat.com, linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org, keyrings@...r.kernel.org,
	linux-crypto@...r.kernel.org, dwmw2@...radead.org
Subject: Re: [RFC PATCH 5/8] KEYS: Provide software public key query function [ver 3]

Mat Martineau <mathew.j.martineau@...ux.intel.com> wrote:

> > +	len = crypto_akcipher_maxsize(tfm);
> > +	info->key_size = len * 8;
> > +	info->max_data_size = len;
> > +	info->max_sig_size = len;
> > +	info->max_enc_size = len;
> > +	info->max_dec_size = len;
> 
> If len > UINT16_MAX, should UINT16_MAX be reported as the max size? Similar
> question for len*8 and key_size.

key_size is 32 bits, but the other sizes are all 16 bits, so you would need a
524288-bit key to exceed their capacity.  I'm not sure that's likely anytime
soon, but should I just make all the sizes 32-bit anyway?

David