linux-kernel - Re: [PATCH 6/6] pinctrl: tegra: Add driver to configure voltage and power state of io pads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57345B4A.8020409@nvidia.com>
Date:	Thu, 12 May 2016 11:30:34 +0100
From:	Jon Hunter <jonathanh@...dia.com>
To:	Stephen Warren <swarren@...dotorg.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Laxman Dewangan <ldewangan@...dia.com>
CC:	Alexandre Courbot <gnurou@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Thierry Reding <thierry.reding@...il.com>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH 6/6] pinctrl: tegra: Add driver to configure voltage and
 power state of io pads


On 11/05/16 17:07, Stephen Warren wrote:
> On 05/11/2016 03:19 AM, Linus Walleij wrote:
>> On Mon, May 2, 2016 at 2:17 PM, Laxman Dewangan <ldewangan@...dia.com>
>> wrote:
>>
>>> NVIDIA Tegra210 supports the IO pads which can operate at 1.8V
>>> or 3.3V I/O voltage levels. Also the IO pads can be configured
>>> for power down state if it is not used. SW needs to configure the
>>> voltage level of IO pads based on IO rail voltage and its power
>>> state based on platform usage.
>>>
>>> The voltage and power state configurations of pads are provided
>>> through pin control frameworks. Add pin control driver for Tegra's
>>> IO pads' voltage and power state configurations.
>>>
>>> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
>>>
>>> ---
>>> Changes from V1:
>>> - Use the generic pincontrol property for low power enable/disable.
>>> - sync with latest and remove all MODULE* macros
>>> - Use renamed APIs form PMC
>>
>> Looks OK to me, need Stephen's ACK though!
> 
> This driver is for HW that's separate from the main Tegra pinmux module.
> Thierry Reding and Jon Hunter are more appropriate reviewers for this one.

There will be another spin of this, so let's wait for the V2.

Cheers
Jon