linux-kernel - Re: [PATCH] mm: fix pfn spans two sections in has_unmovable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5734716D.1070401@suse.cz>
Date:	Thu, 12 May 2016 14:05:01 +0200
From:	Vlastimil Babka <vbabka@...e.cz>
To:	Xishi Qiu <qiuxishi@...wei.com>,
	Naoya Horiguchi <n-horiguchi@...jp.nec.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Mel Gorman <mgorman@...hsingularity.net>,
	Michal Hocko <mhocko@...e.com>,
	David Rientjes <rientjes@...gle.com>,
	"'Kirill A . Shutemov'" <kirill.shutemov@...ux.intel.com>,
	Joonsoo Kim <iamjoonsoo.kim@....com>,
	Taku Izumi <izumi.taku@...fujitsu.com>,
	Alexander Duyck <alexander.h.duyck@...hat.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Linux MM <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: fix pfn spans two sections in has_unmovable_pages()

On 05/12/2016 01:58 PM, Xishi Qiu wrote:
> On 2016/5/12 19:36, Vlastimil Babka wrote:
>
>> On 05/09/2016 12:02 PM, Xishi Qiu wrote:
>>
>> Sounds ok, please try.
>>
>
> Hi Vlastimil and Naoya,
>
> The mainline doesn't have this problem, because commit
> add05cecef80 ("mm: soft-offline: don't free target page in successful
> page migration") fixed it in v4.2.
>
> I guess the above patch can't be applied to older kernel directly.
> So shall we rewrite a new one or backport the whole patches which it depend?

I think it makes most sense here to write a <4.2 specific patch and send 
it just to stable. If the alternative of backporting add05cecef80 would 
be disruptive, mention that in the changelog. Try to pinpoint the commit 
that introduced the bug so the fix can have a proper "Fixes:" header.

> Thanks,
> Xishi Qiu
>
>>>
>>> Thanks,
>>> Xishi Qiu
>>>
>>>>>         for (found = 0, iter = 0; iter < pageblock_nr_pages; iter++) {
>>>>>             unsigned long check = pfn + iter;
>>
>>
>> .
>>
>
>
>