linux-kernel - Re: [PATCH net] drivers: net: Don't print unpopulated net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 May 2016 14:27:10 +0100
From:	Harvey Hunt <harvey.hunt@...tec.com>
To:	David Miller <davem@...emloft.net>
CC:	<robert.jarzmik@...e.fr>, <Baohua.Song@....com>,
	<marcel@...wiler.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] drivers: net: Don't print unpopulated net_device name

Hi David,

On 12/05/16 00:26, David Miller wrote:
> From: Harvey Hunt <harvey.hunt@...tec.com>
> Date: Tue, 10 May 2016 17:43:21 +0100
>
>> @@ -1686,8 +1686,7 @@ dm9000_probe(struct platform_device *pdev)
>>   	}
>>
>>   	if (!is_valid_ether_addr(ndev->dev_addr)) {
>> -		dev_warn(db->dev, "%s: Invalid ethernet MAC address. Please "
>> -			 "set using ifconfig\n", ndev->name);
>> +		dev_warn(db->dev, "Invalid ethernet MAC address. Please set using ifconfig\n");
>>
>>   		eth_hw_addr_random(ndev);
>>   		mac_src = "random";
>
> If we don't print the netdev name, it's harder for the user to see which
> adapter has the problem.
>
> Therefore, it is better if you save some boolean state into a local variable
> here, then print the warning right after register_netdev().
>
> Likewise for the rest of your changes too.
>

Okay, I'll do that for v2.

Thanks,

Harvey