[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20160512153208.GY27098@phenom.ffwll.local>
Date: Thu, 12 May 2016 17:32:08 +0200
From: Daniel Vetter <daniel@...ll.ch>
To: Noralf Trønnes <noralf@...nnes.org>
Cc: dri-devel@...ts.freedesktop.org, daniel@...ll.ch,
linux-kernel@...r.kernel.org, jsarha@...com
Subject: Re: [PATCH v3 2/2] drm: Add helper for simple display pipeline
On Thu, May 12, 2016 at 02:53:26PM +0200, Noralf Trønnes wrote:
> +/**
> + * struct drm_simple_display_pipe - simple display pipeline
> + * @crtc: CRTC control structure
> + * @plane: Plane control structure
> + * @encoder: Encoder control structure
> + * @connector: Connector control structure
> + * @funcs: Pipeline control functions (optional)
> + *
> + * Simple display pipeline with plane, crtc and encoder collapsed into one
> + * entity. It should be initialized by calling drm_simple_display_pipe_init().
> + */
> +struct drm_simple_display_pipe {
> + struct drm_crtc crtc;
> + struct drm_plane plane;
> + struct drm_encoder encoder;
> + struct drm_connector *connector;
> +
> + struct drm_simple_display_pipe_funcs *funcs;
> +};
Same thing as in the previous patch: Function table pointers should be
const. I totally forgot about this.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
Powered by blists - more mailing lists