linux-kernel - Re: [PATCH] net: mvneta: bm: fix dependencies again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87shxnmgvh.fsf@free-electrons.com>
Date:	Thu, 12 May 2016 17:32:34 +0200
From:	Gregory CLEMENT <gregory.clement@...e-electrons.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Marcin Wojtas <mw@...ihalf.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: mvneta: bm: fix dependencies again

Hi Arnd,
 
 On mer., mai 11 2016, Arnd Bergmann <arnd@...db.de> wrote:

> I tried to fix this before, but my previous fix was incomplete
> and we can still get the same link error in randconfig builds
> because of the way that Kconfig treats the
>
> 	default y if MVNETA=y && MVNETA_BM_ENABLE
>
> line that does not actually trigger when MVNETA_BM_ENABLE=m,
> unlike I intended.
> Changing the line to use MVNETA_BM_ENABLE!=n however has
> the desired effect and hopefully makes all configurations
> work as expected.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 019ded3aa7c9 ("net: mvneta: bm: clarify dependencies")

It looks ok for me.

Acked-by: Gregory CLEMENT <gregory.clement@...e-electrons.com>

Thanks,

Gregory

> ---
>  drivers/net/ethernet/marvell/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/Kconfig b/drivers/net/ethernet/marvell/Kconfig
> index b5c6d42daa12..2664827ddecd 100644
> --- a/drivers/net/ethernet/marvell/Kconfig
> +++ b/drivers/net/ethernet/marvell/Kconfig
> @@ -68,7 +68,7 @@ config MVNETA
>  
>  config MVNETA_BM
>  	tristate
> -	default y if MVNETA=y && MVNETA_BM_ENABLE
> +	default y if MVNETA=y && MVNETA_BM_ENABLE!=n
>  	default MVNETA_BM_ENABLE
>  	select HWBM
>  	help
> -- 
> 2.7.0
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com