linux-kernel - Re: [PATCH] Input - ntrig_spi: add new driver for the Surface 3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160512195638.GC25805@dtor-ws>
Date:	Thu, 12 May 2016 12:56:38 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:	Bastien Nocera <hadess@...ess.net>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input - ntrig_spi: add new driver for the Surface 3

On Thu, May 12, 2016 at 09:51:22PM +0200, Benjamin Tissoires wrote:
> On May 12 2016 or thereabouts, Dmitry Torokhov wrote:
> > On Thu, May 12, 2016 at 05:07:54PM +0200, Benjamin Tissoires wrote:
> > > +static int __maybe_unused ntrig_spi_suspend(struct device *dev)
> > > +{
> > > +	struct spi_device *spi = to_spi_device(dev);
> > > +	struct ntrig *data = spi_get_drvdata(spi);
> > > +
> > > +	ntrig_spi_free_irq(data);
> > 
> > Why?
> 
> To disable the IRQ and be sure we won't wake up the device...
> It might just work without though.

Or you can do disable_irq(). Do you want it to be wakeup source by
chance? Then you need to wire it up some more.

Thanks.

-- 
Dmitry