linux-kernel - Re: [PATCH] irqchip: nps: add 64BIT dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57358F52.706@arm.com>
Date:	Fri, 13 May 2016 09:24:50 +0100
From:	Marc Zyngier <marc.zyngier@....com>
To:	Arnd Bergmann <arnd@...db.de>, Jason Cooper <jason@...edaemon.net>
Cc:	Noam Camus <noamc@...hip.com>, Vineet Gupta <vgupta@...opsys.com>,
	linux-snps-arc@...ts.infradead.org,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irqchip: nps: add 64BIT dependency

On 12/05/16 22:03, Arnd Bergmann wrote:
> The newly added nps irqchip driver causes build warnings on ARM64.
> 
> include/soc/nps/common.h: In function 'nps_host_reg_non_cl':
> include/soc/nps/common.h:148:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> 
> As the driver is only used on ARC, we don't need to see it without
> COMPILE_TEST elsewhere, and we can avoid the warnings by only
> building on 32-bit architectures even with CONFIG_COMPILE_TEST.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/irqchip/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 83775f148158..37289cf6b449 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -253,6 +253,7 @@ config MVEBU_ODMI
>  
>  config EZNPS_GIC
>  	bool "NPS400 Global Interrupt Manager (GIM)"
> +	depends on ARC || (COMPILE_TEST && !64BIT)
>  	select IRQ_DOMAIN
>  	help
>  	  Support the EZchip NPS400 global interrupt controller
> 

Acked-by: Marc Zyngier <narc.zyngier@....com>

As I've already started collecting fixes that are aimed at -rc1 (mostly
to avoid dependencies), I can queue that as well.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...