linux-kernel - Re: [PATCH v2 1/2] vb2: core: Skip planes array verification if pb is NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5735A092.5000209@linux.intel.com>
Date:	Fri, 13 May 2016 12:38:26 +0300
From:	Sakari Ailus <sakari.ailus@...ux.intel.com>
To:	Hans Verkuil <hverkuil@...all.nl>, linux-media@...r.kernel.org
Cc:	mchehab@....samsung.com, david@...olicited.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] vb2: core: Skip planes array verification if pb is
 NULL

Hi Hans,

Hans Verkuil wrote:
> On 05/12/2016 02:14 PM, Sakari Ailus wrote:
>> An earlier patch fixing an input validation issue introduced another
>> issue: vb2_core_dqbuf() is called with pb argument value NULL in some
>> cases, causing a NULL pointer dereference. Fix this by skipping the
>> verification as there's nothing to verify.
>>
>> Signed-off-by: David R <david@...olicited.net>
>>
>> Use if () instead of ? :; it's nicer that way. Improve the comment in the
>> code as well.
> 
> This comment doesn't seem applicable to this patch.

Compared to the original patch. I can sure drop the comment as well,
it's not that important.

> 
> Reviewed-by: Hans Verkuil <hans.verkuil@...co.com>

Thanks!

-- 
Sakari Ailus
sakari.ailus@...ux.intel.com