linux-kernel - Re: [PATCH v8 1/7] regulator: fixed: add support for ACPI interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160513111727.GD22038@sirena.org.uk>
Date:	Fri, 13 May 2016 12:17:27 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Lu Baolu <baolu.lu@...ux.intel.com>
Cc:	felipe.balbi@...ux.intel.com,
	Mathias Nyman <mathias.nyman@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Lee Jones <lee.jones@...aro.org>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Liam Girdwood <lgirdwood@...il.com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 1/7] regulator: fixed: add support for ACPI interface

On Thu, May 05, 2016 at 01:32:57PM +0800, Lu Baolu wrote:

> +	gpiod = gpiod_get(dev, "gpio", GPIOD_ASIS);
> +	if (IS_ERR(gpiod))
> +		return ERR_PTR(-ENODEV);

> +	config->gpio = desc_to_gpio(gpiod);
> +	config->enable_high = device_property_read_bool(dev,
> +							"enable-active-high");

> +	gpiod_put(gpiod);

This isn't going to work at all if the GPIO is shared between multiple
regulators but I can't immediately see a sensible way to fix that
without some surgery on the GPIO APIs so let's leave it for now.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)