linux-kernel - Re: [PATCH 1/3] perf diff: Fix indentation of stalled backend cycle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160513140055.GI13997@two.firstfloor.org>
Date:	Fri, 13 May 2016 07:00:55 -0700
From:	Andi Kleen <andi@...stfloor.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Jiri Olsa <jolsa@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH 1/3] perf diff: Fix indentation of stalled backend cycle

On Fri, May 13, 2016 at 03:01:01PM +0900, Namhyung Kim wrote:
> The commit 140aeadc1fb5 ("perf stat: Abstract stat metrics printing")
> changed way to print shadow metrics, but it missed to update the width
> of stalled backend cycles event to 7.2% like others.  This resulted in
> misaligned output like below:

Thanks.

My preferred action would be actually kill
stalled-cycles-frontend/backend.
I don't know any CPU where it is accurate.

TopDown is much better.

But as long as it is kept it is better to align it right.


-Andi