lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 13 May 2016 08:27:29 -0600 From: David Ahern <dsahern@...il.com> To: Hekuang <hekuang@...wei.com>, Arnaldo Carvalho de Melo <arnaldo.melo@...il.com> Cc: peterz@...radead.org, mingo@...hat.com, alexander.shishkin@...ux.intel.com, jolsa@...hat.com, wangnan0@...wei.com, jpoimboe@...hat.com, ak@...ux.intel.com, eranian@...gle.com, namhyung@...nel.org, adrian.hunter@...el.com, sukadev@...ux.vnet.ibm.com, masami.hiramatsu.pt@...achi.com, tumanova@...ux.vnet.ibm.com, kan.liang@...el.com, penberg@...nel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v3 3/7] perf tools: Remove the logical that skip buildid cache if symfs is given On 5/13/16 1:19 AM, Hekuang wrote: >> What about putting the build id cache under the symfs? so instead of >> dropping the symfs check and it to the path for the build id cache. >> >> > I think your intention is to reference symbol files in one place > instead of two. So there're two possible approaches, one is all > in buildid-cache, but in practice, I found lots of binaries in > symfs even not contains valid buildid, so this way is not work. > > The other one is all in symfs. It seems ok, but one problem I > should point out, with my test environment as an example, the > symfsdir is $(TARGET_ROOTFS),and by default buildid_dir is > $(TARGET_ROOTFS)/$(HOME)/.debug/, host perf does not know > $(HOME) folder in target and we should copy the debug folder > to $(TARGET_ROOTFS), which is readonly in the target. For me, it's > easier to use 'buildid-cache -a vdso-xxxx' to add that into host > buildid-cache than copy debug folder from $(HOME) to readonly > $(TARGET_ROOTFS). > > Without the stale concern, I prefer the two places(buildid-dir in > host and target symfs) way. The intention of symfs is every single file opened by perf is relative to that directory. As I recall when I added that option in early 2011 I made sure that statement is true. I think it is best to maintain that design.
Powered by blists - more mailing lists