linux-kernel - Re: [PATCH 2/2] HID: multitouch: enable the Surface 3 Type Cover to report multitouch data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1463155787.17131.351.camel@linux.intel.com>
Date:	Fri, 13 May 2016 19:09:47 +0300
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:	Jiri Kosina <jikos@...nel.org>, Bastien Nocera <hadess@...ess.net>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] HID: multitouch: enable the Surface 3 Type Cover to
 report multitouch data

On Fri, 2016-05-13 at 16:49 +0200, Benjamin Tissoires wrote:
> On May 13 2016 or thereabouts, Andy Shevchenko wrote:
> > 
> > On Thu, 2016-05-12 at 16:12 +0200, Benjamin Tissoires wrote:
> > > 
> > > There is no reasons to filter out keyboard and consumer control
> > > collections
> > > in hid-multitouch.
> > > With the previous hid-input fix, there is now a full support of
> > > the
> > > Type
> > > Cover and we can remove all specific bits from hid-core and hid-
> > > microsoft.
> > > 
> > > hid-multitouch will automatically set HID_QUIRK_NO_INIT_REPORTS so
> > > we
> > > can
> > > also remove it from the list of ushbid quirks.
> > > 
> > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> > > ---
> > > 
> > > Andy, would you mind checking if this series is sufficient to
> > > enable
> > > the
> > > TypeCover of the Surface Book?
> > Tested-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > 
> > Noticed little difference that there is no event for the device
> > anymore,
> > just /dev/usb/hiddev0. Would it work properly under X?
> Not sure what you mean.
> I get 3 input nodes:
> Microsoft Surface Type Cover Keyboard
> Microsoft Surface Type Cover Consumer Control
> Microsoft Surface Type Cover Touchpad
> 
> Each on this input device is properly assigned an event node and X
> works
> with them.
> 
> If there is no /dev/input/eventX created for your cover, then this is
> not normal and needs to be investigated.

There is no /dev/input/eventX for the touchpad. 
It prints that input device is under /usb.../input8, but the actual node
I got events from is /dev/usb/hiddev0.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy