[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <d039b5f5-4b5e-f916-97d5-3d4f186aeb3c@redhat.com>
Date: Fri, 13 May 2016 15:38:34 -0400
From: Doug Ledford <dledford@...hat.com>
To: Muhammad Falak R Wani <falakreyaz@...il.com>,
linux-kernel@...r.kernel.org
Cc: Mike Marciniszyn <infinipath@...el.com>,
Sean Hefty <sean.hefty@...el.com>,
Hal Rosenstock <hal.rosenstock@...il.com>,
linux-rdma@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging/rdma/hfi1: use RCU_INIT_POINTER() when NULLing.
On 05/01/2016 08:35 AM, Muhammad Falak R Wani wrote:
> It is safe to use RCU_INIT_POINTER() to NULL a pointer, instead of
> rcu_assign_pointer().
> This results in slightly smaller/faster code.
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@...il.com>
> ---
> drivers/staging/rdma/hfi1/init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rdma/hfi1/init.c b/drivers/staging/rdma/hfi1/init.c
> index cfcdc16..34e0f90 100644
> --- a/drivers/staging/rdma/hfi1/init.c
> +++ b/drivers/staging/rdma/hfi1/init.c
> @@ -1303,7 +1303,7 @@ static void cleanup_device_data(struct hfi1_devdata *dd)
>
> spin_lock(&ppd->cc_state_lock);
> cc_state = get_cc_state(ppd);
> - rcu_assign_pointer(ppd->cc_state, NULL);
> + RCU_INIT_POINTER(ppd->cc_state, NULL);
> spin_unlock(&ppd->cc_state_lock);
>
> if (cc_state)
>
Thanks, applied.
--
Doug Ledford <dledford@...hat.com>
GPG KeyID: 0E572FDD
Download attachment "signature.asc" of type "application/pgp-signature" (885 bytes)
Powered by blists - more mailing lists