linux-kernel - Re: [lustre-devel] [PATCH] staging: lustre: use setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 13 May 2016 20:42:42 +0100 (BST)
From:	James Simmons <jsimmons@...radead.org>
To:	Muhammad Falak R Wani <falakreyaz@...il.com>
cc:	Oleg Drokin <oleg.drokin@...el.com>, devel@...verdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, lustre-devel@...ts.lustre.org
Subject: Re: [lustre-devel] [PATCH] staging: lustre: use setup_timer().


> Use setup_timer() for initializing the timer, instead of structure
> assignments.
> This is the preferred/standard way.
> 
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@...il.com>

Acked-by: James Simmons <jsimmons@...radead.org>

> ---
>  drivers/staging/lustre/lnet/lnet/net_fault.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lnet/lnet/net_fault.c b/drivers/staging/lustre/lnet/lnet/net_fault.c
> index 7d76f28..e4aceb7 100644
> --- a/drivers/staging/lustre/lnet/lnet/net_fault.c
> +++ b/drivers/staging/lustre/lnet/lnet/net_fault.c
> @@ -760,9 +760,7 @@ lnet_delay_rule_add(struct lnet_fault_attr *attr)
>  		wait_event(delay_dd.dd_ctl_waitq, delay_dd.dd_running);
>  	}
>  
> -	init_timer(&rule->dl_timer);
> -	rule->dl_timer.function = delay_timer_cb;
> -	rule->dl_timer.data = (unsigned long)rule;
> +	setup_timer(&rule->dl_timer, delay_timer_cb, (unsigned long)rule);
>  
>  	spin_lock_init(&rule->dl_lock);
>  	INIT_LIST_HEAD(&rule->dl_msg_list);
> -- 
> 1.9.1
> 
> _______________________________________________
> lustre-devel mailing list
> lustre-devel@...ts.lustre.org
> http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org
>