linux-kernel - Re: [PATCH] zram: introduce per-device debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 14 May 2016 12:37:07 +0900
From:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:	Minchan Kim <minchan@...nel.org>
Cc:	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
	Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH] zram: introduce per-device debug_stat sysfs node

Hello Minchan,

On (05/14/16 08:05), Minchan Kim wrote:
[..]
> > recompress:
> > 	compress
> > 	handle = zs_malloc FAST PATH
> > 
> > 	if (!handle) {
> > 		release stream
> > 		handle = zs_malloc SLOW PATH
> > 
> > 		<< my patch accounts SLOW PATH here >>
> > 
> > 		if (handle) {
> > 			num_recompress++  << NEW version accounts it here, only it was OK >>
> > 			goto recompress;
> > 		}
> > 
> > 		goto err;    << SLOW PATH is not accounted if SLOW PATH was unsuccessful
> > 	}
> > 
> 
> I got your point. You want to account every slow path and change
> the naming from num_recompress to something to show that slow path.

yes :)

> Sorry for catching your point too late. And I absolutely agree with you.
> I want to name it with 'writestall' like MM's allocstall. :)

no problem. 'writestall' is really good, that's the word I was looking
for.

> Now I saw you sent new version but I like your suggestion more.
> 
> I will send new verion by hand :)
> Thanks for the arguing. It was worth!

oh, thanks!

	-ss