lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 14 May 2016 20:34:39 +0200 From: Wim Van Sebroeck <wim@...ana.be> To: Muhammad Falak R Wani <falakreyaz@...il.com> Cc: Guenter Roeck <linux@...ck-us.net>, linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/2] watchdog: cpwd: Use setup_timer() Hi Muhammed, > The function setup_timer combines the initialization of a timer with > the initialization of the timer's function and data fields. > The multiline code for timer initialization is now replaced > with function setup_timer. > > Signed-off-by: Muhammad Falak R Wani <falakreyaz@...il.com> > --- > drivers/watchdog/cpwd.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/watchdog/cpwd.c b/drivers/watchdog/cpwd.c > index 0200768..71ee079 100644 > --- a/drivers/watchdog/cpwd.c > +++ b/drivers/watchdog/cpwd.c > @@ -611,9 +611,7 @@ static int cpwd_probe(struct platform_device *op) > } > > if (p->broken) { > - init_timer(&cpwd_timer); > - cpwd_timer.function = cpwd_brokentimer; > - cpwd_timer.data = (unsigned long) p; > + setup_timer(&cpwd_timer, cpwd_brokentimer, (unsigned long)p); > cpwd_timer.expires = WD_BTIMEOUT; > > pr_info("PLD defect workaround enabled for model %s\n", > -- > 1.9.1 > This patch was added to linux-watchdog-next. Kind Regards, Wim.
Powered by blists - more mailing lists