linux-kernel - Re: [PATCH] iommu/rockchip: fix zap cache during device attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160515111638.GA9715@river>
Date:	Sun, 15 May 2016 12:16:39 +0100
From:	John Keeping <john@...anate.com>
To:	Heiko Stuebner <heiko@...ech.de>
Cc:	iommu@...ts.linux-foundation.org, Joerg Roedel <joro@...tes.org>,
	linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
	ZhengShunQian <zhengsq@...k-chips.com>
Subject: Re: [PATCH] iommu/rockchip: fix zap cache during device attach

On Sat, May 14, 2016 at 10:19:43PM +0200, Heiko Stuebner wrote:
> Am Dienstag, 10. Mai 2016, 16:50:46 schrieb John Keeping:
> > rk_iommu_command() takes a struct rk_iommu and iterates over the slave
> > MMUs, so this is doubly wrong in that we're passing in the wrong pointer
> > and talking to MMUs that we shouldn't be.
> > 
> > Fixes: cd6438c5f844 ("iommu/rockchip: Reconstruct to support multi
> > slaves") Signed-off-by: John Keeping <john@...anate.com>
> 
> on a rk3288-veyron
> Tested-by: Heiko Stuebner <heiko@...ech.de>
> Reviewed-by: Heiko Stuebner <heiko@...ech.de>
> 
> I was wondering for a short time why this didn't spew warnings until I 
> realized that the iommu->bases[i] is of course a void* .

Yes, although sparse catches it because iommu->bases[i] is __iomem so it
shows up as a namespace warning.