linux-kernel - r8169: Unconditionally disabling ASPM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1463330971.6071.35.camel@users.sourceforge.net>
Date:	Sun, 15 May 2016 18:49:31 +0200
From:	Paul Menzel <paulepanter@...rs.sourceforge.net>
To:	Realtek linux nic maintainers <nic_swsd@...ltek.com>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Stanislaw Gruszka <sgruszka@...hat.com>
Subject: r8169: Unconditionally disabling ASPM

Dear Linux folks,

Running the Firmware Test Suite (fwts) [1] on an ASRock E350M1, it
suggests that ASPM should be enabled.

The module r8169 disables ASPM since the commit below.

commit ba04c7c93bbcb48ce880cf75b6e9dffcd79d4c7b
Author: Stanislaw Gruszka <sgruszka@...hat.com>
Date:   Tue Feb 22 02:00:11 2011 +0000

    r8169: disable ASPM

    For some time is known that ASPM is causing troubles on r8169, i.e. make
    device randomly stop working without any errors in dmesg.

    Currently Tomi Leppikangas reports that system with r8169 device hangs
    with MCE errors when ASPM is enabled:
    https://bugzilla.redhat.com/show_bug.cgi?id=642861#c4

    Lets disable ASPM for r8169 devices at all, to avoid problems with
    r8169 PCIe devices at least for some users.

    Reported-by: Tomi Leppikangas <tomi.leppikangas@...il.com>
    Cc: stable@...nel.org
    Signed-off-by: Stanislaw Gruszka <sgruszka@...hat.com>
    Signed-off-by: David S. Miller <davem@...emloft.net>

As over five years have passed now, do you think that is still needed?
I wonder why no module parameter was added back then, where users could
enable ASPM if it works on their systems? Because there is no such
situation and it always fails?

Thanks,

Paul

[1] https://wiki.ubuntu.com/FirmwareTestSuite
Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)