linux-kernel - Re: [patch net-next 06/11] ACPI: bus: move acpi_match_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 May 2016 09:57:33 +0800
From:	"Yankejian (Hackim Yim)" <yankejian@...wei.com>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Yisen Zhuang <Yisen.Zhuang@...wei.com>, <davem@...emloft.net>,
	<rjw@...ysocki.net>, <lenb@...nel.org>
CC:	<arnd@...db.de>, <andrew@...n.ch>, <geliangtang@....com>,
	<ivecera@...hat.com>, <fengguang.wu@...el.com>,
	<charles.chenxin@...wei.com>, <haifeng.wei@...wei.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linuxarm@...wei.com>
Subject: Re: [patch net-next 06/11] ACPI: bus: move acpi_match_device_ids() to
 linux/acpi.h



On 2016/5/13 21:15, Andy Shevchenko wrote:
> On Fri, 2016-05-13 at 16:19 +0800, Yisen Zhuang wrote:
>> From: Hanjun Guo <hanjun.guo@...aro.org>
>>
>> acpi_match_device_ids() will be used for drivers to match
>> different hardware versions, it will be compiled in non-ACPI
>> case, but acpi_match_device_ids() in acpi_bus.h and it can
>> only be used in ACPI case, so move it to linux/acpi.h and
>> introduce a stub function for it.
> I somehow doubt this is right move.
>
> Like I said in the previous comment the architectural split might make
> this a bit better.
>
> You might use 
>
> #ifdef IS_ENABLED(CONFIG_ACPI)
> #else
> #endif
>
> only once to some big part of code. If kernel is build without ACPI
> support you even will not have this in your driver at all.

Hi Andy,

Thanks for your suggestions. It will add stub function instead in next submit.


> -- 
> Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Intel Finland Oy
>
>
> .
>