linux-kernel - Re: [PATCH 5/6] Staging: comedi: Fix WARNING issue in dt2801.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5739A32C.6090905@mev.co.uk>
Date:	Mon, 16 May 2016 11:38:36 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Ravishankar Karkala Mallikarjunayya <ravishankarkm32@...il.com>,
	hsweeten@...ionengravers.com, gregkh@...uxfoundation.org
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] Staging: comedi: Fix WARNING issue in dt2801.c

On 16/05/16 11:18, Ravishankar Karkala Mallikarjunayya wrote:
> This is a patch to the dt2801.c file that fixes up a Block comments
> issues found by the checkpatch.pl tool.
>
> i.e. Block comments use a trailing */ on a separate line
>
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@...il.com>
> ---
>   drivers/staging/comedi/drivers/dt2801.c | 84 ++++++++++++++++-----------------
>   1 file changed, 42 insertions(+), 42 deletions(-)
>

Patch series should start at 1, not 5.  In this case, your two patches 
PATCH 5/6 and PATCH 6/6 look independent from one another, and could be 
posted as individual patches, not in a series.

> diff --git a/drivers/staging/comedi/drivers/dt2801.c b/drivers/staging/comedi/drivers/dt2801.c
> index 6c7b4d2..51f2f75 100644
> --- a/drivers/staging/comedi/drivers/dt2801.c
> +++ b/drivers/staging/comedi/drivers/dt2801.c
> @@ -3,31 +3,30 @@
>    * Device Driver for DataTranslation DT2801
>    *
>    */
> -/*
> -Driver: dt2801
> -Description: Data Translation DT2801 series and DT01-EZ
> -Author: ds
> -Status: works
> -Devices: [Data Translation] DT2801 (dt2801), DT2801-A, DT2801/5716A,
> -  DT2805, DT2805/5716A, DT2808, DT2818, DT2809, DT01-EZ
> -
> -This driver can autoprobe the type of board.
> -
> -Configuration options:
> -  [0] - I/O port base address
> -  [1] - unused
> -  [2] - A/D reference 0=differential, 1=single-ended
> -  [3] - A/D range
> -	  0 = [-10, 10]
> -	  1 = [0,10]
> -  [4] - D/A 0 range
> -	  0 = [-10, 10]
> -	  1 = [-5,5]
> -	  2 = [-2.5,2.5]
> -	  3 = [0,10]
> -	  4 = [0,5]
> -  [5] - D/A 1 range (same choices)
> -*/
> + /* Driver: dt2801
> +  * Description: Data Translation DT2801 series and DT01-EZ
> +  * Author: ds
> +  * Status: works
> +  * Devices: [Data Translation] DT2801 (dt2801), DT2801-A, DT2801/5716A,
> +  * DT2805, DT2805/5716A, DT2808, DT2818, DT2809, DT01-EZ
> +
> +  * This driver can autoprobe the type of board.
> +
> +  * Configuration options:
> +  * [0] - I/O port base address
> +  * [1] - unused
> +  * [2] - A/D reference 0=differential, 1=single-ended
> +  * [3] - A/D range
> +  *	  0 = [-10, 10]
> +  *	  1 = [0,10]
> +  * [4] - D/A 0 range
> +  *	  0 = [-10, 10]
> +  *	  1 = [-5,5]
> +  *	  2 = [-2.5,2.5]
> +  *	  3 = [0,10]
> +  *	  4 = [0,5]
> +  * [5] - D/A 1 range (same choices)
> +  */

Our usual block comment style is:

/*
  * blah blah
  * blah blah
  */

i.e. the opening '/*' is on a line by itself.  If you could fix up the 
block comments to conform to that style, that would be great!

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-