linux-kernel - Re: [lkp] [xfs] a08ee40a79: kmsg.XFS(vdd):unknown_mount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8b490c2a-505d-bba2-c4a9-b85732505dc5@sandeen.net>
Date:	Mon, 16 May 2016 10:46:04 -0500
From:	Eric Sandeen <sandeen@...deen.net>
To:	kernel test robot <xiaolong.ye@...el.com>
Cc:	Dave Chinner <david@...morbit.com>,
	Brian Foster <bfoster@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>, lkp@...org
Subject: Re: [lkp] [xfs] a08ee40a79:
 kmsg.XFS(vdd):unknown_mount_option[nosuchopt]

On 5/15/16 8:42 PM, kernel test robot wrote:
> FYI, we noticed the following commit:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> commit a08ee40a79653d082911cab9fbeff94baa7714cb ("xfs: sanitize remount options")
> 
> on test machine: vm-kbuild-4G: 4 threads qemu-system-x86_64 -enable-kvm -cpu qemu64,+ssse3 with 4G memory
> 
> caused below changes:
> 
> 
> [  666.729855] XFS (vdd): unknown mount option [nosuchopt].

This is expected, it's just that we're catching invalid remount options, now,
and being a bit noiser about it.

                default:
                        xfs_warn(mp, "unknown mount option [%s].", p);
                        return -EINVAL;

>From tests/generic/082 :

# first remount ro with a bad option, a failed remount ro should not disable
# quota, but currently xfs doesn't fail in this case, the unknown option is
# just ignored, but quota is still on. This may change in future, let's
# re-consider the case then.
_scratch_mount "-o remount,ro,nosuchopt" >>$seqres.full 2>&1

so the test is intentionally passing in a bad mount option, and the kernel
is just letting us know.

Thanks,
-Eric