lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 May 2016 18:06:05 +0100 From: Catalin Marinas <catalin.marinas@....com> To: Yury Norov <ynorov@...iumnetworks.com> Cc: arnd@...db.de, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org, linux-s390@...r.kernel.org, pinskia@...il.com, Prasun.Kapoor@...iumnetworks.com, heiko.carstens@...ibm.com, linux-doc@...r.kernel.org, Nathan_Lynch@...tor.com, agraf@...e.de, klimov.linux@...il.com, Andrew Pinski <Andrew.Pinski@...iumnetworks.com>, broonie@...nel.org, bamvor.zhangjian@...wei.com, Andrew Pinski <apinski@...ium.com>, schwab@...e.de, schwidefsky@...ibm.com, joseph@...esourcery.com, christoph.muellner@...obroma-systems.com Subject: Re: [PATCH 20/25] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it On Sat, May 14, 2016 at 06:03:52PM +0300, Yury Norov wrote: > +SYSCALL_DEFINE6(mmap2, unsigned long, addr, unsigned long, len, > + unsigned long, prot, unsigned long, flags, unsigned long, fd, > + unsigned long, pgoff) To avoid the types confusion we could add __SC_WRAP to mmap2 in unistd.h and use COMPAT_SYSCALL_DEFINE6 here (together with compat_ptr_t etc.). > +{ > + if (pgoff & (~PAGE_MASK >> 12)) > + return -EINVAL; > + > + return sys_mmap_pgoff((compat_uptr_t) addr, (compat_size_t) len, > + (int) prot, (int) flags, (int) fd, > + pgoff >> (PAGE_SHIFT-12)); Then we wouldn't need the explicit casting here. > +} > + > +COMPAT_SYSCALL_DEFINE4(pread64, unsigned int, fd, compat_uptr_t __user *, ubuf, > + compat_size_t, count, off_t, offset) > +{ > + return sys_pread64(fd, (char *) ubuf, count, offset); > +} > + > +COMPAT_SYSCALL_DEFINE4(pwrite64, unsigned int, fd, compat_uptr_t __user *, ubuf, > + compat_size_t, count, off_t, offset) > +{ > + return sys_pwrite64(fd, (char *) ubuf, count, offset); Nitpick: no space between cast type and variable name: (char *)ubuf, ... We can also make these functions static as they are not used outside this file. -- Catalin
Powered by blists - more mailing lists