linux-kernel - Re: [PATCH] dell_rbu: Don't fallback to userhelper when loading firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 May 2016 10:12:21 -0700
From:	Laura Abbott <labbott@...hat.com>
To:	Mario Limonciello <mario_limonciello@...l.com>,
	ming.lei@...onical.com
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dell_rbu: Don't fallback to userhelper when loading
 firmware

On 05/16/2016 08:41 AM, Mario Limonciello wrote:
> dell_rbu previously would allow a userspace application to craft the
> payload after dell_rbu was loaded and abuse the udev userspace API.
>
> Instead require the payload to be crafted and placed in
> /lib/firmware/dell_rbu ahead of time.
>
> This adjusts dell_rbu to immediately load the firmware from
> /lib/firmware/dell_rbu when "init" is passed into image_type using the
> kernel helper.

Looks like you missed the Signed-off-by line.

Can you also drop the Kconfig dependency on CONFIG_FW_LOADER_USER_HELPER?

Thanks,
Laura

> ---
>  drivers/firmware/dell_rbu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/dell_rbu.c b/drivers/firmware/dell_rbu.c
> index d5f5b98..5ecf043 100644
> --- a/drivers/firmware/dell_rbu.c
> +++ b/drivers/firmware/dell_rbu.c
> @@ -677,7 +677,7 @@ static ssize_t write_rbu_image_type(struct file *filp, struct kobject *kobj,
>  		if (!rbu_data.entry_created) {
>  			spin_unlock(&rbu_data.lock);
>  			req_firm_rc = request_firmware_nowait(THIS_MODULE,
> -						      FW_ACTION_NOHOTPLUG,
> +						      FW_ACTION_HOTPLUG,
>  						      "dell_rbu",
>  						      &rbu_device->dev,
>  						      GFP_KERNEL,
>