linux-kernel - RE: [PATCH v2 6/8] crypto: caam - handle core endianness != caam endianness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB13118EA25CF114C4D638AE39B8770@VI1PR04MB1311.eurprd04.prod.outlook.com>
Date:	Mon, 16 May 2016 14:52:50 +0000
From:	Tudor-Dan Ambarus <tudor-dan.ambarus@....com>
To:	Horia Ioan Geanta Neag <horia.geanta@....com>,
	Herbert Xu <herbert@...dor.apana.org.au>
CC:	"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Scott Wood <scott.wood@....com>,
	"Alexandru Porosanu" <alexandru.porosanu@....com>,
	Cristian Stoica <cristian.stoica@....com>,
	Fabio Estevam <fabio.estevam@....com>,
	"Steven Cornelius" <steve.cornelius@....com>
Subject: RE: [PATCH v2 6/8] crypto: caam - handle core endianness != caam
 endianness

> There are SoCs like LS1043A where CAAM endianness (BE) does not match
> the default endianness of the core (LE).
> Moreover, there are requirements for the driver to handle cases like
> CPU_BIG_ENDIAN=y on ARM-based SoCs.
> This requires for a complete rewrite of the I/O accessors.
> 
> PPC-specific accessors - {in,out}_{le,be}XX - are replaced with
> generic ones - io{read,write}[be]XX.
> 
> Endianness is detected dynamically (at runtime) to allow for
> multiplatform kernels, for e.g. running the same kernel image
> on LS1043A (BE CAAM) and LS2080A (LE CAAM) armv8-based SoCs.
> 
> While here: debugfs entries need to take into consideration the
> endianness of the core when displaying data. Add the necessary
> glue code so the entries remain the same, but they are properly
> read, regardless of the core and/or SEC endianness.
> 
> Note: pdb.h fixes only what is currently being used (IPsec).
> 
> Signed-off-by: Horia Geantă <horia.geanta@....com>
> Signed-off-by: Alex Porosanu <alexandru.porosanu@....com>
> ---
>  drivers/crypto/caam/Kconfig       |   4 -
>  drivers/crypto/caam/caamhash.c    |   5 +-
>  drivers/crypto/caam/ctrl.c        | 125 +++++++++++++++++++------------
>  drivers/crypto/caam/desc.h        |   7 +-
>  drivers/crypto/caam/desc_constr.h |  44 +++++++----
>  drivers/crypto/caam/jr.c          |  22 +++---
>  drivers/crypto/caam/pdb.h         | 137 ++++++++++++++++++++++++++--------
>  drivers/crypto/caam/regs.h        | 151 +++++++++++++++++++++++++---------
> ----
>  drivers/crypto/caam/sg_sw_sec4.h  |  11 +--
>  9 files changed, 340 insertions(+), 166 deletions(-)

Reviewed-by: Tudor Ambarus <tudor-dan.ambarus@....com>