lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 May 2016 10:53:42 -0700 From: Dmitry Torokhov <dmitry.torokhov@...il.com> To: 廖崇榮 <kt.liao@....com.tw> Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, zac.hsieh@....com.tw, 黃世鵬 經理 <phoenix@....com.tw>, 'Charles Mooney' <charliemooney@...gle.com>, 'Agnes Cheng' <agnescheng@...gle.com> Subject: Re: [PATCH] Input: Change BTN_TOOL_FINGER flag when hover event trigger Hi Kt, On Mon, May 16, 2016 at 07:27:25PM +0800, 廖崇榮 wrote: > > Only ABS_DISTANCE is not enough for upper OS to distingiush hover event be > triggered from object from faraway to and close touchpad surface or from > object prepare to leave the touchpad surface. Add BTN_TOOL_FINGER flag to > help it. > > object_from_faraway object_inside_hover_area > object_touch_surface > BTN_TOUCH 0 0 1 > BTN_TOOL_FINGER 0 1 1 > ABS_DISTANCE 0 1 0 > > Signed-off by: Duson Lin <dusonlin@....com.tw> I was wondering if we could do without modifying all the drivers that are using input_mt_report_pointer_emulation(), by figuring out if we should be emitting BTN_TOOL_FINGER right there: "If device supports ABS_DISTANCE and does not support ABS_MT_DISTANCE and ABS_DISTANCE != 0 is reported in current frame and there are no other contacts then report BTN_TOOL_FINGER." Thanks. -- Dmitry
Powered by blists - more mailing lists