linux-kernel - Re: [PATCH] ixgbe: take online CPU number as MQ max limit when alloc_etherdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1463432322.2609.12.camel@intel.com>
Date:	Mon, 16 May 2016 13:58:42 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Ethan Zhao <ethan.zhao@...cle.com>, jesse.brandeburg@...el.com,
	shannon.nelson@...el.com, carolyn.wyborny@...el.com,
	donald.c.skidmore@...el.com, bruce.w.allan@...el.com,
	john.ronciak@...el.com, mitch.a.williams@...el.com,
	intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, ethan.kernel@...il.com
Subject: Re: [PATCH] ixgbe: take online CPU number as MQ max limit when 
 alloc_etherdev_mq()

On Fri, 2016-05-13 at 14:56 +0900, Ethan Zhao wrote:
> Allocating 64 Tx/Rx as default doesn't benefit perfomrnace when less
> CPUs were assigned. especially when DCB is enabled, so we should take
> num_online_cpus() as top limit, and aslo to make sure every TC has
> at least one queue, take the MAX_TRAFFIC_CLASS as bottom limit of queues
> number.
> 
> Signed-off-by: Ethan Zhao <ethan.zhao@...cle.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 ++++
>  1 file changed, 4 insertions(+)

Dropping this patch based on Alex's and John's feedback.
Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)