lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Mon, 16 May 2016 19:19:34 -0300
From:	"Guilherme G. Piccoli" <gpiccoli@...ux.vnet.ibm.com>
To:	Minfei Huang <mnghuan@...il.com>
Cc:	keith.busch@...el.com, axboe@...com, linux-kernel@...r.kernel.org,
	linux-nvme@...ts.infradead.org
Subject: Re: [PATCH] Use MICRO UINT_MAX instead of actual value

On 04/30/2016 07:13 AM, Minfei Huang wrote:
> Ping.
>
> Any comment is appreciate.

Hi Minfei, I guess a good idea would be to resend the patch with the 
typo fixed, as a v2 patch. What do you think?

Cheers,


Guilherme

>
> Thanks
> Minfei
>
> On 04/25/16 at 11:13P, Minfei Huang wrote:
>> It's more elegant to use MICRO UINT_MAX to represent the max value of
>> type unsigned int. So replace the actual value by using this MICRO.
>>
>> Signed-off-by: Minfei Huang <mnghuan@...il.com>
>> ---
>>   drivers/nvme/host/core.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
>> index 643f457..2c0bb13 100644
>> --- a/drivers/nvme/host/core.c
>> +++ b/drivers/nvme/host/core.c
>> @@ -597,7 +597,7 @@ static void nvme_config_discard(struct nvme_ns *ns)
>>
>>   	ns->queue->limits.discard_alignment = logical_block_size;
>>   	ns->queue->limits.discard_granularity = logical_block_size;
>> -	blk_queue_max_discard_sectors(ns->queue, 0xffffffff);
>> +	blk_queue_max_discard_sectors(ns->queue, UINT_MAX);
>>   	queue_flag_set_unlocked(QUEUE_FLAG_DISCARD, ns->queue);
>>   }
>>
>> --
>> 2.6.3
>>
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
>

Powered by blists - more mailing lists