linux-kernel - Re: [PATCH 1/2] Create UV efi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160516230011.GM98477@stormcage.americas.sgi.com>
Date:	Mon, 16 May 2016 18:00:11 -0500
From:	Alex Thorlton <athorlton@....com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	Alex Thorlton <athorlton@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Dimitri Sivanich <sivanich@....com>,
	Russ Anderson <rja@....com>, Mike Travis <travis@....com>,
	Matt Fleming <matt@...eblueprint.co.uk>,
	Borislav Petkov <bp@...e.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	"x86@...nel.org" <x86@...nel.org>,
	"linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>
Subject: Re: [PATCH 1/2] Create UV efi_call macros

On Thu, May 12, 2016 at 10:17:39AM +0200, Ingo Molnar wrote:
> > Fine by me, although having a newline after arch_efi_call_virt_setup()
> > but not before arch_efi_call_virt_teardown() seems rather arbitrary
> 
> It's an oversight! :-)
> 
> #define efi_call_virt(f, args...)					\
> ({									\
> 	efi_status_t __s;						\
> 	unsigned long flags;						\
> 									\
> 	arch_efi_call_virt_setup();					\
> 									\
> 	local_save_flags(flags);					\
> 	__s = arch_efi_call_virt(f, args);				\
> 	efi_call_virt_check_flags(flags, __stringify(f));		\
> 									\
> 	arch_efi_call_virt_teardown();					\
> 									\
> 	__s;								\
> })
> 
> But if it's too segmented this is fine too:
> 
> #define efi_call_virt(f, args...)					\
> ({									\
> 	efi_status_t __s;						\
> 	unsigned long flags;						\
> 									\
> 	arch_efi_call_virt_setup();					\
> 	local_save_flags(flags);					\
> 	__s = arch_efi_call_virt(f, args);				\
> 	efi_call_virt_check_flags(flags, __stringify(f));		\
> 	arch_efi_call_virt_teardown();					\
> 									\
> 	__s;								\
> })

This makes sense to me.  I'll make sure to include something like this
in my next version of the patch.

Thanks, guys!

- Alex