lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 17 May 2016 10:02:22 +0900
From:	Minchan Kim <minchan@...nel.org>
To:	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	<linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Subject: Re: [PATCH v5 07/12] zsmalloc: factor page chain functionality out

On Mon, May 16, 2016 at 11:14:20AM +0900, Sergey Senozhatsky wrote:
> On (05/09/16 11:20), Minchan Kim wrote:
> > For page migration, we need to create page chain of zspage dynamically
> > so this patch factors it out from alloc_zspage.
> > 
> > Cc: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> > Signed-off-by: Minchan Kim <minchan@...nel.org>
> 
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>

Thanks!

> 
> [..]
> > +		page = alloc_page(flags);
> > +		if (!page) {
> > +			while (--i >= 0)
> > +				__free_page(pages[i]);
> 
> 				put_page() ?
> 
> a minor nit, put_page() here probably will be in alignment
> with __free_zspage(), which does put_page().

Normally, we use put_page in case that someone can grab a referece of
the page so we cannot free the page. Otherwise, alloc_page and
__free_page is more straight to me code readability POV.

> 
> 	-ss
> 
> > +			return NULL;
> > +		}
> > +		pages[i] = page;
> >  	}
> >  
> > +	create_page_chain(pages, class->pages_per_zspage);
> > +	first_page = pages[0];
> > +	init_zspage(class, first_page);
> > +
> >  	return first_page;
> >  }

Powered by blists - more mailing lists