linux-kernel - Re: [RFC][PATCH] printk: Add option to append kernel version to the dict

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160517100840.GZ4775@htj.duckdns.org>
Date:	Tue, 17 May 2016 03:08:40 -0700
From:	Tejun Heo <tj@...nel.org>
To:	Petr Mladek <pmladek@...e.com>
Cc:	Calvin Owens <calvinowens@...com>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Howells <dhowells@...hat.com>,
	Pranith Kumar <bobby.prani@...il.com>,
	David Woodhouse <David.Woodhouse@...el.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
	Vasily Averin <vvs@...tuozzo.com>,
	Thierry Reding <treding@...dia.com>,
	Geliang Tang <geliangtang@....com>,
	Ivan Delalande <colona@...sta.com>,
	linux-kernel@...r.kernel.org, kernel-team@...com
Subject: Re: [RFC][PATCH] printk: Add option to append kernel version to the
 dict

Hello,

On Tue, May 17, 2016 at 11:24:46AM +0200, Petr Mladek wrote:
> The risk is that someone else might need another information.
> If we do it more generic, we might end up with quite complex code.

It can be pretty simple given that there's no real ordering or
formatting involved.

  enum {
	  ECON_APPEND_RELEASE	= 1 << 0,
  ];

  static unsigned int ext_con_append_mask;

  static int __init ext_con_append_setup(char *str)
  {
	  while (*str) {
		  switch (*str) {
			  case 'r':
				  ext_con_append_mask |= ECON_APPEND_RELEASE;
				  break;
			  default:
				  pr_warning("Unknown ext ext con append format '%c'\n", *str);
		  }
		  str++;
	  }
	  return 1;
  }
  __setup("ext_con_append=", ext_con_append_setup);

And we can expand the list as necessary.  I don't think it needs to be
a compile time option either.  The code involved is minimal after all.

Thanks.

-- 
tejun