linux-kernel - Re: [PATCH v3 1/7 UPDATE2] perf tools: Find vdso with the consider of cross-platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160517124617.GD3455@kernel.org>
Date:	Tue, 17 May 2016 09:46:17 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Adrian Hunter <adrian.hunter@...el.com>
Cc:	He Kuang <hekuang@...wei.com>, peterz@...radead.org,
	mingo@...hat.com, alexander.shishkin@...ux.intel.com,
	jolsa@...hat.com, wangnan0@...wei.com, jpoimboe@...hat.com,
	ak@...ux.intel.com, eranian@...gle.com, namhyung@...nel.org,
	sukadev@...ux.vnet.ibm.com, masami.hiramatsu.pt@...achi.com,
	tumanova@...ux.vnet.ibm.com, kan.liang@...el.com,
	penberg@...nel.org, dsahern@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/7 UPDATE2] perf tools: Find vdso with the consider
 of cross-platform

Em Tue, May 17, 2016 at 12:17:29PM +0300, Adrian Hunter escreveu:
> On 17/05/16 12:04, He Kuang wrote:
> > There's a problem in machine__findnew_vdso(), vdso buildid generated
> > by a 32-bit machine stores it with the name 'vdso', but when
> > processing buildid on a 64-bit machine with the same 'perf.data', perf
> > will search for vdso named as 'vdso32' and get failed.

> > This patch tries to find the exsiting dsos in machine->dsos by thread
> > dso_type. 64-bit thread tries to find vdso with name 'vdso', because
> > all 64-bit vdso is named as that. 32-bit thread first tries to find
> > vdso with name 'vdso32' if this thread was run on 64-bit machine, if
> > failed, then it tries 'vdso' which indicates that the thread was run
> > on 32-bit machine when recording.

> > Signed-off-by: He Kuang <hekuang@...wei.com>
 
> Looks OK.
 
> Acked-by: Adrian Hunter <adrian.hunter@...el.com>

Thanks, applied.

- Arnaldo