lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAJfpeguDRps94_NYXSjc7gtO7OYMU-BEwU3nqp8XABtZ5Cftcg@mail.gmail.com> Date: Tue, 17 May 2016 16:24:43 +0200 From: Miklos Szeredi <miklos@...redi.hu> To: Vivek Goyal <vgoyal@...hat.com> Cc: Miklos Szeredi <mszeredi@...hat.com>, Daniel Axtens <dja@...ens.net>, Al Viro <viro@...iv.linux.org.uk>, linux-fsdevel <linux-fsdevel@...r.kernel.org>, "linux-unionfs@...r.kernel.org" <linux-unionfs@...r.kernel.org>, Kernel Mailing List <linux-kernel@...r.kernel.org>, mpe@...erman.id.au, dchinner@...hat.com Subject: Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker On Tue, May 17, 2016 at 2:10 PM, Vivek Goyal <vgoyal@...hat.com> wrote: > Having said that, what happens when ovl_workdir_create() fails and we > mount overlayfs read only. In that case I think we will conclude that > underlying fs does not support d_type and mounting will fail. Good point, I missed that. > Any thoughts, on how to handle this failure path better? Just skip the d_type test. We won't create whiteouts that way (and whiteouts would only have been created with a previous kernel that didn't have this test, which I don't think is a very interesting case). Thanks, Miklos
Powered by blists - more mailing lists