linux-kernel - Re: [PATCH] coccicheck: Fix missing 0 index in kill loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1605171633460.3068@hadrien>
Date:	Tue, 17 May 2016 16:33:58 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	"Nicolas Palix (LIG)" <Nicolas.Palix@...g.fr>
cc:	Kees Cook <keescook@...omium.org>,
	Julia Lawall <Julia.Lawall@...6.fr>,
	linux-kernel@...r.kernel.org,
	Gilles Muller <Gilles.Muller@...6.fr>,
	Michal Marek <mmarek@...e.com>, cocci@...teme.lip6.fr
Subject: Re: [PATCH] coccicheck: Fix missing 0 index in kill loop



On Tue, 17 May 2016, Nicolas Palix (LIG) wrote:

> Le 16/05/16 14:55, Kees Cook a écrit :
> > By default, "seq" counts from 1, but processes were starting counting
> > from 0, so when interrupted, coccicheck would leave the 0th process
> > running.
> >
> > Signed-off-by: Kees Cook <keescook@...omium.org>
>
> Acked-by: Nicolas Palix <nicolas.palix@...g.fr>

Acked-by: Julia Lawall <julia.lawall@...6.fr>

>
>
> > ---
> >  scripts/coccicheck | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/coccicheck b/scripts/coccicheck
> > index b2d758188f2f..dd85a455b2ba 100755
> > --- a/scripts/coccicheck
> > +++ b/scripts/coccicheck
> > @@ -98,7 +98,7 @@ run_cmd() {
> >  }
> >
> >  kill_running() {
> > -	for i in $(seq $(( NPROC - 1 )) ); do
> > +	for i in $(seq 0 $(( NPROC - 1 )) ); do
> >  		if [ $VERBOSE -eq 2 ] ; then
> >  			echo "Killing ${SPATCH_PID[$i]}"
> >  		fi
> >
>
>
> --
> Nicolas Palix
> http://lig-membres.imag.fr/palix/
>
>