linux-kernel - Re: [PATCH 20/31] thermal: core: introduce thermal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 May 2016 07:40:45 -0700
From:	Eduardo Valentin <edubezval@...il.com>
To:	"Zhang, Rui" <rui.zhang@...el.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>
Subject: Re: [PATCH 20/31] thermal: core: introduce thermal_helpers.c

On Tue, May 17, 2016 at 01:20:17PM +0000, Zhang, Rui wrote:
> $checkpatch.pl 20-31-thermal-core-introduce-thermal_helpers.c.patch 
> 
> WARNING: added, moved or deleted file(s), does MAINTAINERS need
> updating?
> #187: 
> new file mode 100644
> 
> ERROR: trailing whitespace
> #302: FILE: drivers/thermal/thermal_helpers.c:111:
> + $
> 
> WARNING: please, no spaces at the start of a line
> #302: FILE: drivers/thermal/thermal_helpers.c:111:
> + $
> 
> total: 1 errors, 2 warnings, 287 lines checked
> 
> NOTE: Whitespace errors detected.
>       You may wish to use scripts/cleanpatch or scripts/cleanfile
> 
> 20-31-thermal-core-introduce-thermal_helpers.c.patch has style problems,
> please review.
> 
> NOTE: If any of the errors are false positives, please report
>       them to the maintainer, see CHECKPATCH in MAINTAINERS.
> 
> Please remove these spaces.
> BTW, there are also some warnings in the other patches, please fix the
> checkpatch warnings/errors.

Yeah, I will fix those.

These patches were supposed to be reviewed/merged before the merge
window though. I am going to wait until the merge window is closed to
send them again.


BR,

Eduardo Valentin