linux-kernel - Re: [RFC][PATCH] printk: Add option to append kernel version to the dict

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 17 May 2016 09:05:29 -0700
From:	Tejun Heo <tj@...nel.org>
To:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Cc:	Calvin Owens <calvinowens@...com>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Howells <dhowells@...hat.com>,
	Pranith Kumar <bobby.prani@...il.com>,
	David Woodhouse <David.Woodhouse@...el.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	Petr Mladek <pmladek@...e.com>,
	Vasily Averin <vvs@...tuozzo.com>,
	Thierry Reding <treding@...dia.com>,
	Geliang Tang <geliangtang@....com>,
	Ivan Delalande <colona@...sta.com>,
	linux-kernel@...r.kernel.org, kernel-team@...com
Subject: Re: [RFC][PATCH] printk: Add option to append kernel version to the
 dict

On Wed, May 18, 2016 at 12:43:10AM +0900, Sergey Senozhatsky wrote:
> > Given that most of the messages are written minding typical console
> > widths, whether for editing or outputting, I don't think that's a
> > practical concern.  We're not talking about appending kilobytes worth
> > of additional information here.
> 
> hm, I'd probably agree. any chance printk(KERN_CONT) can cause any problems?
> for example,

Plain printk messages are capped at around 1k (LONG_LINE_MAX) while
extended messages can grow upto 8k in size.  Because extended messages
are escaped, plain message can theoretically be blown upto 4k but that
still leaves us with 4k buffer.  Direct extended messages can use more
but given that our only usages are for tagging some metadata, that's
only a theoretical possibility at this point.  So, I don't think we
have anything to worry about at this point.

Thanks.

-- 
tejun