linux-kernel - Re: [PATCH v2 net] drivers: net: Don't print unpopulated net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160517.123121.1984109840595169844.davem@davemloft.net>
Date:	Tue, 17 May 2016 12:31:21 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	harvey.hunt@...tec.com
Cc:	marcel@...wiler.com, robert.jarzmik@...e.fr, Baohua.Song@....com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net] drivers: net: Don't print unpopulated
 net_device name

From: Harvey Hunt <harvey.hunt@...tec.com>
Date: Tue, 17 May 2016 14:33:27 +0100

> For ethernet devices, net_device.name will be eth%d before
> register_netdev() is called. Don't print the net_device name until
> the format string is replaced.
> 
> Signed-off-by: Harvey Hunt <harvey.hunt@...tec.com>
> Cc: Marcel Ziswiler <marcel@...wiler.com>
> Cc: Robert Jarzmik <robert.jarzmik@...e.fr>
> Cc: Barry Song <Baohua.Song@....com>
> Cc: netdev@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org 
> ---
> v1 -> v2:
>  - Replace ifconfig with ip
>  - Delay printk until the netdev name is known

Yeah this looks a lot better, applied, thanks!