linux-kernel - Re: [RFC][WARNING] warning in uncore_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1605172124200.3851@nanos>
Date:	Tue, 17 May 2016 21:34:40 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Jiri Olsa <jolsa@...hat.com>
cc:	Andi Kleen <andi@...stfloor.org>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>,
	x86@...nel.org, Ingo Molnar <mingo@...nel.org>
Subject: Re: [RFC][WARNING] warning in uncore_pci_probe

On Tue, 17 May 2016, Jiri Olsa wrote:
> 
> [    2.766466] WARNING: CPU: 0 PID: 1 at arch/x86/events/intel/uncore.c:894 uncore_pci_probe+0x2a8/0x2b0
> 
> I'm booting with nr_cpus=1, which impact physical_to_logical_pkg
> setup.. the map will not be initialized because the rest of cpus
> is never initialized and set in cpu_present_mask
>
> it seems to me we should remove the warning, because it's valid to
> have only single cpu allowed

Single package that is. The package map for cpu 0 is correct, i.e. package 0,
but that code tries to init the PCI/uncore for the other packages.

So, yes. The WARN_ON() is wrong there. We should just return and be done with
it.

Thanks,

	tglx