linux-kernel - Re: [1/1] net: pegasus: remove dead coding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1463555740.22748.0.camel@suse.com>
Date:	Wed, 18 May 2016 09:15:40 +0200
From:	Oliver Neukum <oneukum@...e.com>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	Heinrich Schuchardt <xypron.glpk@....de>,
	Petko Manolov <petkan@...leusys.com>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [1/1] net: pegasus: remove dead coding

On Tue, 2016-05-17 at 23:30 -0700, Guenter Roeck wrote:
> On Wed, May 18, 2016 at 02:13:30AM +0200, Heinrich Schuchardt wrote:
> > (!count || count < 4) is always true.
> 
> Even if count >= 4 ?

The check for !count is redundant, though. Gcc, however,
will surely simplify the expression.

	Regards
		Oliver