linux-kernel - Re: linux-4.6/drivers/crypto/ux500/hash/hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160518074650.GA6097@gondor.apana.org.au>
Date:	Wed, 18 May 2016 15:46:50 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	David Binderman <linuxdev.baldrick@...il.com>
Cc:	davem@...emloft.net, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org, dcb314@...mail.com,
	Andreas Westin <andreas.westin@...ricsson.com>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: linux-4.6/drivers/crypto/ux500/hash/hash_core.c: 2 * possible
 bad size ?

On Mon, May 16, 2016 at 07:13:12PM +0100, David Binderman wrote:
> Hello there,
> 
> 1.
> 
> linux-4.6/drivers/crypto/ux500/hash/hash_core.c:784]: (warning) Division by
> result of sizeof(). memmove() expects a size in bytes, did you intend to
> multiply instead?
> 
> Source code is
> 
>                 memmove(req_ctx->state.buffer,
>                     device_data->state.buffer,
>                     HASH_BLOCK_SIZE / sizeof(u32));
> 
> Maybe better code
> 
>                 memmove(req_ctx->state.buffer,
>                     device_data->state.buffer,
>                     HASH_BLOCK_SIZE);
> 
> 2.
> 
> linux-4.6/drivers/crypto/ux500/hash/hash_core.c:835]: (warning) Division by
> result of sizeof(). memmove() expects a size in bytes, did you intend to
> multiply instead?
> 
> Duplicate.

Thanks for noticing these bugs.  This driver hasn't been maintained
since 2012, so unless someone steps up I'm going to just delete it.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt