linux-kernel - Re: [PATCH] Staging: comedi: quatech_daqp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <573C2E8B.1040009@mev.co.uk>
Date:	Wed, 18 May 2016 09:57:47 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Amit Ghadge <amitg.b14@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: Fix a unsigned
 warning issue

On 17/05/16 17:53, Amit Ghadge wrote:
> This is a patch to the quatech_daqp_cs.c file that fixes by using
> unsigned int instead of unsigned, following warning found by checkpatch.
> * WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
>
> Signed-off-by: Amit Ghadge <amitg.b14@...il.com>
> ---
>   drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> index e9e4313..802f51e 100644
> --- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> +++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> @@ -643,7 +643,7 @@ static int daqp_ao_insn_write(struct comedi_device *dev,
>   	outb(0, dev->iobase + DAQP_AUX_REG);
>
>   	for (i = 0; i > insn->n; i++) {
> -		unsigned val = data[i];
> +		unsigned int val = data[i];
>   		int ret;
>
>   		/* D/A transfer rate is about 8ms */
>

Thanks!

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-