linux-kernel - Re: [PATCH] virtio_balloon: fix PFN format for virtio-1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160518152746.1d6abdc2.cornelia.huck@de.ibm.com>
Date:	Wed, 18 May 2016 15:27:46 +0200
From:	Cornelia Huck <cornelia.huck@...ibm.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	virtualization@...ts.linux-foundation.org,
	Christian Borntraeger <borntraeger@...ibm.com>
Subject: Re: [PATCH] virtio_balloon: fix PFN format for virtio-1

On Wed, 18 May 2016 15:38:53 +0300
"Michael S. Tsirkin" <mst@...hat.com> wrote:

> Everything should be LE when using virtio-1, but
> the linux balloon driver does not seem to care about that.
> 
> Cc: stable@...r.kernel.org
> Reported-by: Cornelia Huck <cornelia.huck@...ibm.com>
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> ---
>  drivers/virtio/virtio_balloon.c | 20 ++++++++++++--------
>  1 file changed, 12 insertions(+), 8 deletions(-)

Keeping the pfns in proper byte order seems less hacky than my
approach, and it fixes the crash for my setup as well.

Tested-by: Cornelia Huck <cornelia.huck@...ibm.com>
Reviewed-by: Cornelia Huck <cornelia.huck@...ibm.com>